Add smoldot-based WebRTC dialer #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove some unused deps
Author
|
I would also like to update the table in the README but with so many combinations being tested, it now takes forever to run |
Author
I've updated the table now by running only the missing pairs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal WebRTC dialer based on the smoldot codebase that implements the litep2p-perf protocol.
It is based off #2, so this PR should be reviewed and merged first.
In order to run this, the host machine needs to have Chrome installed. The
headless_chromecrate can download a Chrome binary if necessary. This could be enabled, but for now I've opted not to.Other requirements apart from a Rust toolchain are an installed
wasm32-unknown-unknowntarget as well as thewasm-bindgen-clicrate, which needs to be installed in the exact same version as is used in thesmoldot-perfpackage. This is checked in thesmoldot-automationexecutable.I tried to run the dialer in Docker, but ran into networking issues I was unable to resolve.
One limitation I've noticed is that the
performance.now()function available in the browser for measuring time passed lacks the necessary precision to measure the bandwidth for small amounts of data, like 1 kiB.So far this PR encompasses only connecting from a dialer in Chrome to a litep2p-based listener. We could also add a libp2p-based listener and/or run the dialer in Firefox. But I'd suggest we add that in a follow-up PR.